Refactor Seed Dataset to improve compatibility and simplify usage #1734
+649
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
initialized from HF/Pytorch/JSON/list of Dicts, remove the need for setup call and subsequently cleanup
2 tasks
2 tasks
This was
linked to
issues
Mar 7, 2025
hallerite
requested changes
Mar 7, 2025
test coverage
instead of strings and add seed for reproducibility
between simply skipping invalid datapoints in a seed dataset and throwing an exception
seed dataset to ensure they are defined before the other functions are
to store data in Seed Dataset
changes in base.py
requirements
getitem and cast len(data) to a Sized to pass mypy tests
hallerite
requested changes
Mar 10, 2025
| ), "Dataset does not support indexing." | ||
|
|
||
| self._raw_data = [dict(data[i]) for i in range(len(data))] | ||
| elif isinstance(data, Path): |
There was a problem hiding this comment.
Let's add some more safety features here. The current configuration does not:
- check if the list contains only dictionaries
- check if the file is valid JSON before attempting to load
- handle potential encoding issues
| validating each against the DataPoint schema. | ||
| This class can initialize from Hugging Face Datasets, | ||
| PyTorch Datasets, JSON file paths, or lists of dictionaries, | ||
| converting them into a consistent internal format. | ||
| """ | ||
|
|
||
| def __init__( |
There was a problem hiding this comment.
This __init__ is getting really messy. It would be better to create specific methods to handle the conversion.
| logger.debug("No raw data to process") | ||
| return | ||
|
|
||
| def create_datapoint( |
There was a problem hiding this comment.
This method is supposed to validate whether a dict is a valid DataPoint. Providing default values for non-existant Keys defeats the whole purpose.
Note that it should not fail if there are extra fields.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR solves:
#1732
#1733
Checklist
Go over all the following points, and put an
xin all the boxes that apply.Fixes #issue-numberin the PR description (required)pyproject.tomlandpoetry.lockIf you are unsure about any of these, don't hesitate to ask. We are here to help!